Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune sentry collection rates per docs #6121

Merged
merged 1 commit into from
Nov 16, 2023
Merged

tune sentry collection rates per docs #6121

merged 1 commit into from
Nov 16, 2023

Conversation

bmuenzenmeyer
Copy link
Collaborator

Description

This PR tunes down the sentry collection rates

Sentry was kind enough to reset our quote, but https://docs.sentry.io/platforms/javascript/performance/ and https://docs.sentry.io/platforms/javascript/session-replay/ suggest to lower the rate once setup is complete.

with this change we are:

  • tracing at 1%
  • sampling at 1%
  • recording errors at 100%

This work can sit until we talk with the Sentry folks, and serve as a useful outcome of any ongoing discussion. I'll be emailing them a link to it.

Validation

  • Locally the app still runs
  • Sentry should still collect.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team November 16, 2023 03:55
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner November 16, 2023 03:55
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 16, 2023 3:55am

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Nov 16, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 16, 2023
Copy link

github-actions bot commented Nov 16, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 97 🟠 83 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/blog 🟢 99 🟢 97 🟠 83 🟢 92 🔗

@ovflowd
Copy link
Member

ovflowd commented Nov 16, 2023

Thank you, @bmuenzenmeyer! Going to merge this ASAP so that we don't overuse our quotas again!

Much thanks to Sentry!

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
79.86% (357/447) 65.45% (72/110) 63.73% (58/91)

Unit Test Report

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 4.928s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit a88030e Nov 16, 2023
21 checks passed
@ovflowd ovflowd deleted the tune-sentry branch November 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants